exception

Hi this is full class.Now there is one difference between this and previous post I have uncommented one line dataforce line{0}

so now exception also slightly chnaged to

java.lang.IllegalArgumentException: Required string is empty

at com.dhl.auditdatamgr.utils.db.DataUtil.enforceNotNullOrEmpty(DataUtil.java:81)

at com.dhl.auditdatamgr.utils.AuditFileParser.parseFile(AuditFileParser.java:75)

at com.dhl.auditdatamgr.process.AuditDataHandler.main(AuditDataHandler.java:94)

package com.dhl.auditdatamgr.utils;

import java.io.BufferedInputStream;

import java.io.BufferedReader;

import java.io.File;

import java.io.FileInputStream;

import java.io.FileNotFoundException;

import java.io.FileReader;

import java.io.IOException;

import java.io.InputStream;

import java.text.ParseException;

import java.util.ArrayList;

import java.util.List;

import java.util.StringTokenizer;

import java.util.regex.Pattern;

import com.dhl.auditdatamgr.business.DetailedFacilityAuditData;

import com.dhl.auditdatamgr.exceptions.ParserException;

import com.dhl.auditdatamgr.utils.db.DataUtil;

public class AuditFileParser

{

/**

* Constructor

*/

protected AuditFileParser()

{

super();

}

public static List parseFile(String fileName, String regex)

throws IllegalArgumentException, FileNotFoundException, ParserException

{

DataUtil.enforceNotNullOrEmpty(fileName);

DataUtil.enforceNotNullOrEmpty(regex);

List rowList = new ArrayList();

BufferedReader br = null;

try

{

br = new BufferedReader(

new FileReader(new File(fileName)));

String line = null;

DetailedFacilityAuditData detailedAuditData = null;

Integer huExpected = null;

Integer huMissing = null;

Integer huExtra = null;

Integer shipmentExpected = null;

Integer shipmentMissing = null;

Integer shipmentExtra = null;

Integer pieceIdsExpected = null;

Integer pieceIdsMissing = null;

Integer pieceIdsExtra = null;

Pattern p = Pattern.compile(regex);

while((line = br.readLine()) != null)

{

//System.out.println("Line: " + line);

//Pattern p = Pattern.compile("[\\p{Punct}&&[|]]");

String [] lineItems = p.split(line);

detailedAuditData = new DetailedFacilityAuditData();

DataUtil.enforceNotNullOrEmpty(lineItems[0]);

DataUtil.enforceNotNullOrEmpty(lineItems[5]);

DataUtil.enforceNotNullOrEmpty(lineItems[6]);

DataUtil.enforceNotNullOrEmpty(lineItems[3]);

detailedAuditData.setHuid(lineItems[0]);

System.out.println("Shipment gadexpected is: " + lineItems[0]);

detailedAuditData.setAuditAtServiceArea(lineItems[5]);

System.out.println("Shipment bcexpected is: " + lineItems[5]);

detailedAuditData.setAuditAtFacility(lineItems[6]);

System.out.println("Shipmentgexpected is: " + lineItems[6]);

detailedAuditData.setAuditTime(DataUtil.convertToTimestamp(lineItems[3]));

System.out.println("Shipment uexpected is: " + lineItems[3]);

detailedAuditData.setHuType(lineItems[4]);

System.out.println("Shipment expected is: " + lineItems[4]);

detailedAuditData.setBuiltAtServiceArea(lineItems[1]);

System.out.println("Shipment expected is: " + lineItems[1]);

detailedAuditData.setBuiltAtFacility(lineItems[2]);

System.out.println("Shipment expected is: " + lineItems[2]);

if(lineItems[9] != null && !lineItems[9].equals(""))

{ System.out.println("Shipment expected is: " + lineItems[9]);

huExpected = new Integer(Integer.parseInt(lineItems[9]));

detailedAuditData.setHuExpected(huExpected);

}

if(lineItems[12] != null && !lineItems[12].equals(""))

{System.out.println("Shipment expected is: " + lineItems[12]);

huMissing = new Integer(Integer.parseInt(lineItems[12]));

detailedAuditData.setHuMissing(huMissing);

}

if(lineItems[13] != null && !lineItems[13].equals(""))

{System.out.println("Shipment expected is: " + lineItems[13]);

huExtra = new Integer(Integer.parseInt(lineItems[13]));

detailedAuditData.setHuExtra(huExtra);

}

if(lineItems[7] != null && !lineItems[7].equals(""))

{

System.out.println("Shipment expected is: " + lineItems[7]);

shipmentExpected = new Integer(Integer.parseInt(lineItems[7]));

detailedAuditData.setShipmentExpected(shipmentExpected);

}

if(lineItems[10] != null && !lineItems[10].equals(""))

{System.out.println("Shipment expected is: " + lineItems[10]);

shipmentMissing = new Integer(Integer.parseInt(lineItems[10]));

detailedAuditData.setShipmentMissing(shipmentMissing);

}

if(lineItems[11] != null && !lineItems[11].equals(""))

{System.out.println("Shipment expected is: " + lineItems[11]);

shipmentExtra = new Integer(Integer.parseInt(lineItems[11]));

detailedAuditData.setShipmentExtra(shipmentExtra);

}

if(lineItems[8] != null && !lineItems[8].equals(""))

{System.out.println("Shipment expected is: " + lineItems[8]);

pieceIdsExpected = new Integer(Integer.parseInt(lineItems[8]));

detailedAuditData.setPieceIdsExpected(pieceIdsExpected);

}

if(lineItems[14] != null && !lineItems[14].equals(""))

{System.out.println("Shipment expected is: " + lineItems[14]);

pieceIdsMissing = new Integer(Integer.parseInt(lineItems[14]));

detailedAuditData.setPieceIdsMissing(pieceIdsMissing);

}

if(lineItems[15] != null && !lineItems[15].equals(""))

{System.out.println("Shipment expected is: " + lineItems[15]);

pieceIdsExtra = new Integer(Integer.parseInt(lineItems[15]));

detailedAuditData.setPieceIdsExtra(pieceIdsExtra);

}

detailedAuditData.setAuditor(lineItems[16]);

System.out.println("Shipment expected is: " + lineItems[16]);

detailedAuditData.setAuditDate(DataUtil.convertToDate(lineItems[17]));

System.out.println("Shipment zexpected is: " + lineItems[17]);

rowList.add(detailedAuditData);

}

}

catch (IOException e)

{

throw new ParserException("An error occurred while trying to read the audit data file. " ,e);

//e.printStackTrace();

} catch (ParseException e)

{

throw new ParserException("An error occurred while parsing the audit data file. " ,e);

//e.printStackTrace();

}

catch (ArrayIndexOutOfBoundsException ae)

{

throw new ParserException("A required field is missing. " ,ae);

}

finally

{

try

{

br.close();

} catch (IOException e1)

{

e1.printStackTrace();

}

}

return rowList;

}

/**

*

* @param fileName - File name or directory to be deleted

* @return true if and only if the file is successfully deleted, false otherwise

* @throws IllegalArgumentException

*/

public static boolean deleteFile(String fileName)

throws IllegalArgumentException

{

DataUtil.enforceNotNullOrEmpty(fileName);

File f = new File(fileName);

boolean deleteStatus = false;

deleteStatus = f.delete();

return deleteStatus;

}

}

smita_smitaa at 2007-7-14 21:30:13 >

java.lang.IllegalArgumentException: Required string is empty

at com.dhl.auditdatamgr.utils.db.DataUtil.enforceNotNullOrEmpty(DataUtil.java:81)

at com.dhl.auditdatamgr.utils.AuditFileParser.parseFile(AuditFileParser.java:75)

at com.dhl.auditdatamgr.process.AuditDataHandler.main(AuditDataHandler.java:94)

Your own code is telling you: a required string is empty.

Line 75 of your AuditFileParser calls that DataUtil method to make sure that the value is not null or empty.

Either the input is null or empty OR the logic in the method is incorrect.

Print it out and see what the value is before you enter that method.

%

duffymoa at 2007-7-14 21:30:13 >

> > excellent point, Monica.

>

> Thanks. This kind of stuff drove me nuts on the Java

> project I was on [the one I always complain about

> here ;-) ].

They're lucky to have you to educate them.

> We had 'new String("literal")'

> everywhere, too. We even had things like 'new

> Integer(1).toString()' with (and without) the

> constant input. And 'Integer.parseInt("1")' with the

> literal String (as well as 'new

> Integer(someString).intValue()'.

Oh, my. Those must have been some fun code reviews.

I see a lot of folks write this:

ArrayList list = new ArrayList();

Instead of this:

List list = new ArrayList();

A peeve of mine. Prefer interfaces when you have a choice.

> I'm on a C++

> (yech!) project now, but haven't started coding yet.

What's wrong with C++? I used to like it. 8) Last time I wrote it was in 2001. I found that my Java had an influence on C++. I used CppUnit to good advantage and did more with exceptions than I had before I learned Java.

%

duffymoa at 2007-7-14 21:30:13 >

Hi I have done my work fully but not getting at all.

i am able to print all file from the file but still error.

second thing If i commecnte lineitem0 exception changes to required filed missing caused by arrayindexoutof bounf:5

thats y i postes all files in link that post

regards

smita_smitaa at 2007-7-21 10:13:51 >

1- Create a data file with only ONE data line that causes the exception.

2- Modify your code with added printlns for debug:while((line = br.readLine()) != null)

{

...

String[] lineItems = p.split(line);

System.out.println("regex="+regex);

System.out.println("line="+line);

System.out.println("lineItems.length="+lineItems.length);

System.out.println("lineItems="+java.util.Arrays.toString(lineItems));

...

3- Execute your program with the one-line data file.

4- Look at the console printout.

Is it the expected results? What is different from it?

jfbrierea at 2007-7-21 10:13:51 >

hI jfbriere

Thanxs for your help.it worked finally.

I was checking with one line of data only so now no problem.

I hope there will be no problem with multiline of data also

thanxs once again.it was real great help.

and thanxs to cotton m also.

Thanxs and regards

smita_smitaa at 2007-7-21 10:13:56 >

java.lang.IllegalArgumentException: Required string is empty

at com.dhl.auditdatamgr.utils.db.DataUtil.enforceNotNullOrEmpty(DataUtil.java:81)

at com.dhl.auditdatamgr.utils.AuditFileParser.parseFile(AuditFileParser.java:75)

at com.dhl.auditdatamgr.process.AuditDataHandler.main(AuditDataHandler.java:94)

smita_smitaa at 2007-7-21 10:13:57 >

Hi here is the code for java and sample text file .

The issue is it is reading al lines but after reading fourth line it is givng this error.it is not able to understand that file has come to an end and try to read fifth line which is not there

1)

import java.io.BufferedInputStream;

import java.io.BufferedReader;

import java.io.File;

import java.io.FileInputStream;

import java.io.FileNotFoundException;

import java.io.FileReader;

import java.io.IOException;

import java.io.InputStream;

import java.text.ParseException;

import java.util.ArrayList;

import java.util.List;

import java.util.StringTokenizer;

import java.util.regex.Pattern;

import com.dhl.auditdatamgr.business.DetailedFacilityAuditData;

import com.dhl.auditdatamgr.exceptions.ParserException;

import com.dhl.auditdatamgr.utils.db.DataUtil;

/**

* @author mahiseth

*

*/

public class AuditFileParser

{

/**

* Constructor

*/

protected AuditFileParser()

{

super();

}

public static List parseFile(String fileName, String regex)

throws IllegalArgumentException, FileNotFoundException, ParserException

{

DataUtil.enforceNotNullOrEmpty(fileName);

DataUtil.enforceNotNullOrEmpty(regex);

List rowList = new ArrayList();

BufferedReader br = null;

try

{

br = new BufferedReader(

new FileReader(new File(fileName)));

String line = null;

DetailedFacilityAuditData detailedAuditData = null;

Integer huExpected = null;

Integer huMissing = null;

Integer huExtra = null;

Integer shipmentExpected = null;

Integer shipmentMissing = null;

Integer shipmentExtra = null;

Integer pieceIdsExpected = null;

Integer pieceIdsMissing = null;

Integer pieceIdsExtra = null;

Pattern p = Pattern.compile(regex);

while((line = br.readLine()) != null)

{

//System.out.println("Line: " + line);

//Pattern p = Pattern.compile("[\\p{Punct}&&[|]]");

////if (lineItems.length != 18)

//continue;

String [] lineItems = p.split(line);

detailedAuditData = new DetailedFacilityAuditData();

System.out.println("regex="+regex);

System.out.println("line="+line);

System.out.println("lineItems.length="+lineItems.length);

DataUtil.enforceNotNullOrEmpty(lineItems[0]);

DataUtil.enforceNotNullOrEmpty(lineItems[5]);

DataUtil.enforceNotNullOrEmpty(lineItems[6]);

DataUtil.enforceNotNullOrEmpty(lineItems[3]);

detailedAuditData.setHuid(lineItems[0]);

detailedAuditData.setAuditAtServiceArea(lineItems[5]);

detailedAuditData.setAuditAtFacility(lineItems[6]);

detailedAuditData.setAuditTime(DataUtil.convertToTimestamp(lineItems[3]));

detailedAuditData.setHuType(lineItems[4]);

detailedAuditData.setBuiltAtServiceArea(lineItems[1]);

detailedAuditData.setBuiltAtFacility(lineItems[2]);

if(lineItems[9] != null && !lineItems[9].equals(""))

{

huExpected = new Integer(Integer.parseInt(lineItems[9]));

detailedAuditData.setHuExpected(huExpected);

}

if(lineItems[12] != null && !lineItems[12].equals(""))

{

huMissing = new Integer(Integer.parseInt(lineItems[12]));

detailedAuditData.setHuMissing(huMissing);

}

if(lineItems[13] != null && !lineItems[13].equals(""))

{

huExtra = new Integer(Integer.parseInt(lineItems[13]));

detailedAuditData.setHuExtra(huExtra);

}

if(lineItems[7] != null && !lineItems[7].equals(""))

{

System.out.println("Shipment expected is: " + lineItems[7]);

shipmentExpected = new Integer(Integer.parseInt(lineItems[7]));

detailedAuditData.setShipmentExpected(shipmentExpected);

}

if(lineItems[10] != null && !lineItems[10].equals(""))

{

shipmentMissing = new Integer(Integer.parseInt(lineItems[10]));

detailedAuditData.setShipmentMissing(shipmentMissing);

}

if(lineItems[11] != null && !lineItems[11].equals(""))

{

shipmentExtra = new Integer(Integer.parseInt(lineItems[11]));

detailedAuditData.setShipmentExtra(shipmentExtra);

}

if(lineItems[8] != null && !lineItems[8].equals(""))

{

pieceIdsExpected = new Integer(Integer.parseInt(lineItems[8]));

detailedAuditData.setPieceIdsExpected(pieceIdsExpected);

}

if(lineItems[14] != null && !lineItems[14].equals(""))

{

pieceIdsMissing = new Integer(Integer.parseInt(lineItems[14]));

detailedAuditData.setPieceIdsMissing(pieceIdsMissing);

}

if(lineItems[15] != null && !lineItems[15].equals(""))

{

pieceIdsExtra = new Integer(Integer.parseInt(lineItems[15]));

detailedAuditData.setPieceIdsExtra(pieceIdsExtra);

}

detailedAuditData.setAuditor(lineItems[16]);

detailedAuditData.setAuditDate(DataUtil.convertToDate(lineItems[17]));

rowList.add(detailedAuditData);

}

}

catch (IOException e)

{

throw new ParserException("An error occurred while trying to read the audit data file. " ,e);

//e.printStackTrace();

} catch (ParseException e)

{

throw new ParserException("An error occurred while parsing the audit data file. " ,e);

//e.printStackTrace();

}

catch (ArrayIndexOutOfBoundsException ae)

{

throw new ParserException("A required field is missing. " ,ae);

}

finally

{

try

{

br.close();

} catch (IOException e1)

{

e1.printStackTrace();

}

}

return rowList;

}

/**

*

* @param fileName - File name or directory to be deleted

* @return true if and only if the file is successfully deleted, false otherwise

* @throws IllegalArgumentException

*/

public static boolean deleteFile(String fileName)

throws IllegalArgumentException

{

DataUtil.enforceNotNullOrEmpty(fileName);

File f = new File(fileName);

boolean deleteStatus = false;

deleteStatus = f.delete();

return deleteStatus;

}

}

2)H480988672|AAA|AAA|2006-09-23 06:23:57|B|AAA|AAA|1|0|0|0|0|0|10|0|0|mcannone|2006-09-23|

H573193578|KAA|KAA|2006-09-23 06:23:58|B|KAA|KAA|21|0|2|0|0|0|0|0|0|pgarcia|2006-09-23|

H583114428|KAA|KAA|2006-09-23 06:23:59|B|KAA|KAA|2221|0|2|0|0|0|0|0|0|pgarcia|2006-09-23|

H480985619|AAA|AAA|2006-09-23 06:23:56|B|AAA|AAA|3|0|3|0|0|0|9|0|0|mcannone|2006-09-23|

smita_smitaa at 2007-7-21 10:13:57 >

here is some output from cosole

upto fourth line it is reading .for fifth line is eqal to blank but functionally it should not try to read fifth line as there is no fifth line.

line=H480985619|AAA|AAA|2006-09-23 06:23:56|B|AAA|AAA|3|0|3|0|0|0|9|0|0|mcannone|2006-09-23|

lineItems.length=18

Shipment expected is: 3

regex=[\p{Punct}&&[|]]

line=

lineItems.length=1

smita_smitaa at 2007-7-21 10:13:57 >

> NO Ron not working .i changed it but no effect

It's Monica, not Ron. It wasn't supposed to have an effect. It just a style issue (same as the others I posted earlier in this thread, which you haven't fixed yet).

If you go into Notepad with your file, and hit Ctrl-End, is there a blank line between the data and your cursor?

MLRona at 2007-7-21 10:14:02 >

Hi monica code is working now I am able to read all those data

but still one issue I dont want touch the file manually.

one person suggested me folwoing code but when I am using that I am not able to read the data file completely.some data left then some read then again left then again read.any idea?

while((line = br.readLine()) != null){

if (lineItems.length != 18)continue;

smita_smitaa at 2007-7-21 10:14:06 >

> for example if the file has 100 records it is reading

> only 60

It's a conspiracy. The runtime just can't stand your inept coding, so it punishes you. It's really trying to tell you to get out of the business of writing software, but it can't speak your language so you'll understand. So it does the only thing it can.

warnerjaa at 2007-7-21 10:14:06 >

Now theses are the sample lines.Now if i put code to check the lines limit it is reading first value and then directly goes to fourth value.

but if I dont put the code then it is reading all lines but i manually need to put cursor at the end of file which should not be

H480987102|AAA|AAA|2006-09-25 16:24:49|B|AAA|AAA|14|10|0|2|0|2|2|0|0|mcannone|2006-09-25|

H480987103|AAA|AAA|2006-09-25 16:26:50|B|AAA|AAA|1400|10|0|2|0|2|2|0|0|mcannone|2006-09-25|

H480987104|AAA|AAA|2006-09-25 16:29:51|B|AAA|AAA|14|0|0|0|0|0|0|0|0|mcannone|2006-09-25|

H480986936|BAA|BAA|2006-09-25 16:22:39|B|BAA|BAA|13|0|2|20|10|0|10|0|0|mcannone|2006-09-25|

smita_smitaa at 2007-7-21 10:14:07 >