java servlet gone bad help
Trying to code java servlet and getting try catch and finally errors when I compile. I am new to java and had to modify a servlet for class in order to insert into mysql data. If anyone can assist be greatly appreciated.
Here is the code.
package com.users.servlet;
import com.users.model.UserAccount;
import javax.servlet.*;
import javax.servlet.http.*;
import java.io.*;
import java.sql.*;
import java.util.List;
@SuppressWarnings({"UnusedAssignment"})
public class InsertUsersServlet extends HttpServlet {
private PreparedStatement st;
public boolean doPost(
Connection conn) {
UserAccount db = null;
String tableRows = "";
try {
( db= new UserAccount("mysite","root","admin"));
st = conn.createStatement();
int i = st.executeUpdate("INSERT INTO useraccount (login,first,last,address,email,phone)values('login','first','last','address','emial','phone')");
return i != -1;
}
catch(Exception ex2) {
ex2.printStackTrace();
return;
}
ServletRequest request();
request.setAttribute("tablerows",tableRows);
final RequestDispatcher view =
((request.getRequestDispatcher("listusers.jsp"))
(( view.forward(request, response)
}
}
}
[1341 byte] By [
javaclassa] at [2007-11-27 10:07:27]
First, surround your code with code tags. Second, describe the error you are encountering.
Here are the errors:
.\src\com\users\servlet\InsertUsersServlet.java:27: 'try' without 'catch' or 'fi
nally'
try {
^
.\src\com\users\servlet\InsertUsersServlet.java:45: illegal start of type
catch (Exception ex2) {
^
.\src\com\users\servlet\InsertUsersServlet.java:51: <identifier> expected
request.setAttribute("tablerows" , tableRows);
^
.\src\com\users\servlet\InsertUsersServlet.java:55: <identifier> expected
view.forward(request, response);
^
.\src\com\users\servlet\InsertUsersServlet.java:58: 'class' or 'interface' expec
ted
}
^
.\src\com\users\servlet\InsertUsersServlet.java:63: 'class' or 'interface' expec
ted
Here is the code :
package com.users.servlet;
import com.users.model.UserAccount;
import javax.servlet.*;
import javax.servlet.http.*;
import java.io.*;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.List;
public class InsertUsersServlet extends HttpServlet {
public void doPost(HttpServletRequest request,
HttpServletResponse response)
throws IOException, ServletException {
response.setContentType("text/html");
UserAccount db = null;
String tableRows = "";
try {
db = new UserAccount ("mysite", "root", "admin");
st = conn.createStatement();
int i = st.executeUpdate("INSERT INTO useraccount (login,first,last,address,email,phone)values('login','first','last','address','emial','phone')");
if (i == -1) {
return false;
}
return true;
}
}
catch (Exception ex2) {
ex2.printStackTrace(); //error making query
return;//bye bye
}
request.setAttribute("tablerows" , tableRows);
RequestDispatcher view =
request.getRequestDispatcher("listusers.jsp");
view.forward(request, response);
}
}
}
> Here are the errors:
>
>
> .\src\com\users\servlet\InsertUsersServlet.java:27:
> 'try' without 'catch' or 'fi
> nally'
> try {
> ^
> .\src\com\users\servlet\InsertUsersServlet.java:45:
> illegal start of type
> catch (Exception ex2) {
> ^
> .\src\com\users\servlet\InsertUsersServlet.java:51:
> <identifier> expected
> request.setAttribute("tablerows" , tableRows);
> ^
> va:55: <identifier> expected
>view.forward(request, response);
> ^
> ers\servlet\InsertUsersServlet.java:58: 'class' or
> 'interface' expec
> ted
>}
> ^
> .\src\com\users\servlet\InsertUsersServlet.java:63:
> 'class' or 'interface' expec
> ted
>
> Here is the code :
>
> package com.users.servlet;
>
> import com.users.model.UserAccount;
> import javax.servlet.*;
> import javax.servlet.http.*;
> import java.io.*;
> import java.sql.Connection;
> import java.sql.DriverManager;
> import java.sql.ResultSet;
> import java.sql.SQLException;
> import java.sql.Statement;
> import java.util.List;
>
>
> public class InsertUsersServlet extends HttpServlet
> {
>
>public void doPost(HttpServletRequest request,
>HttpServletResponse response)
>throws IOException, ServletException {
>response.setContentType("text/html");
>
>UserAccount db = null;
>String tableRows = "";
> try {
>
>db = new UserAccount ("mysite", "root", "admin");
>
>st = conn.createStatement();
> int i = st.executeUpdate("INSERT INTO useraccount
> (login,first,last,address,email,phone)values('login',
> first','last','address','emial','phone')");
>
>
> if (i == -1) {
>return false;
>
>return true;
>
>
> }
> catch (Exception ex2) {
>ex2.printStackTrace(); //error making query
> return;//bye bye
>
> }
>
> request.setAttribute("tablerows" , tableRows);
>
> RequestDispatcher view =
>request.getRequestDispatcher("listusers.jsp");
> view.forward(request, response);
>}
>}
you have a try block without a catch. Normally a try block should be as follows:-
try{
........
}catch(Exception e){
.........
}finally{
......
}
thanks that helped alot for those errors down to 2 however the line number errors that they are referring do have not code on them.
.\src\com\users\servlet\InsertUsersServlet.java:59: 'class' or 'interface' expec
ted
}
^
.\src\com\users\servlet\InsertUsersServlet.java:64: 'class' or 'interface' expec
ted
^
2 errors
Sorry for the lack of knowledge here.
Please don't tell us where those lines are in the file. That wouldn't be sporting.
