Putting user input into a inner panel onto one line

You define the spinners and combo box and label as class variables, not local variables. Then in the actionPerformed method of the "Calculate" button you can get the values from the the above objects and then set the text of the label.

There is no need for the ActionListeners or ChangeListener to be added to the above components.

camickra at 2007-7-29 19:27:29 >

> I thought they were local variables

They are local variables. I am suggesting that you make them class variables. When you make them a class variable then any method in the class can access them.

You don't care what the values of the spinners and combo box are until you click on the "Calculate" button. So the only listener you need in your code is the ActionListener. The code in your listener would then be something like:

System.out.println( spinner1.getValue() );

System.out.println( comboBox.setSeletedItem() );

System.out.println( spinner2.getValue() );

You can then save each of the above 3 variables and format them however you want for you output label.

camickra at 2007-7-29 19:27:29 >

why would you want to add those things to a jpanel? You can't just add text or any old objects to a jpanel. They have to be swing components. It doesn't make sense. I would think that you would rather want to update your result textField with a calculated result.

petes1234a at 2007-7-29 19:27:29 >

Yes that is what I'm trying to do too.

But I can't find a way to put the text into the JTextField for the calculated result.

I also have to do the same thing, but display the equation in the blue bordered box.

I have updated my code for the "Calculate" button anonymous class:

-I think I have converted the spinner values into integers

//Button

JPanel bottomPanel = new JPanel();

add(bottomPanel, BorderLayout.SOUTH);

calculateButton = new JButton("Calculate");

calculateButton.addActionListener(new ActionListener()

{

public void actionPerformed(ActionEvent e)

{

//converting spinner to integers

int numvalue = ((Number)number1.getValue()).intValue();

int num2value = ((Number)number2.getValue()).intValue();

System.out.print( numvalue);

System.out.print( operation.getSelectedItem() );

System.out.print( num2value );

System.out.println("\nok");

String text = result.getText();

}

}

);

bottomPanel.add(calculateButton);

vopoa at 2007-7-29 19:27:29 >

> I was trying to show you that by using a

> System.out.println(...) you could print the value of

> each component.

>

> So the next logical step was to get each value as a

> String and then concatenate all the value together in

> the way you want the output formatted and then use

> label.setText(...) on the formatted String. Basically

> do what your equationDisplay(...) method does, except

> you update the text of your display label.

I'm not sure if I am doing this right so far, can you give me some input on my code.

Here's my code:

//Button

JPanel bottomPanel = new JPanel();

add(bottomPanel, BorderLayout.SOUTH);

calculateButton = new JButton("Calculate");

calculateButton.addActionListener(new ActionListener()

{

public void actionPerformed(ActionEvent e)

{

JLabel label = new JLabel();

//converting spinner to integers

int numvalue = ((Number)number1.getValue()).intValue();

int num2value = ((Number)number2.getValue()).intValue();

String s = new String();

String one = s.valueOf(numvalue);

String two = s.valueOf(operation.getSelectedItem());

String three = s.valueOf(num2value);

label.setText(one + two + three);

workspace.add(label);

System.out.println("\nok");

}

}

);

bottomPanel.add(calculateButton);

vopoa at 2007-7-29 19:27:30 >

> > display = new JLabel(" ");

> > display.setForeground(Color.blue);

> >

> display.setBorder(BorderFactory.createCompoundBorder

> > (BorderFactory.createLineBorder(Color.blue),

> > BorderFactory.createEmptyBorder(0,0,0,0) ));

> > workspace.add(display);

> You have already created and added a label to your

> workspace.

>

> You don't add a new label to the workspace. All you

> need to do is refresh the text of the label with the

> values from the 3 components (at least thats what I

> think you are trying to do).

>

> If that doesn't help, then I don't understand your

> problem.

Here's my problem, I'm trying to make the spinner and combobox text to appear in the workspace panel.

-when the program starts, the workspace panel should begin with:0+0

-when one of the spinners or combobox is changed, they should also change too at the same time:1-0

-to calculate the numbers, the user has to click the "calculate" button, then the answer will appear in the textfield

I hope thats specific enough about my problem

vopoa at 2007-7-29 19:27:30 >

> > I hope thats specific enough about my problem

>

> Yes, its clearer.

>

> So you go back to your orignal design where you have

> listeners on the spinners and the combo box. When an

> event is fired you get the values from all three

> components (in a String) formate and update your

> label with the combined values of all three

> components. You listener would simple invoke a common

> routine shared be the listener. Since all the

> variables are class variable, then can be referenced

> from any method.

How can I combine the different listeners into one from the original?

With the anonymous classes, I can't seem to retrieve the strings from those classes.

Here's my code:

-I have updated the code back to the original design

-I tried to combine the strings together from the listeners, but it doesn't seem that it will grab them.

package 620524.labs;

import java.awt.*;

import java.text.DecimalFormat;

import java.text.NumberFormat;

import javax.swing.*;

import java.awt.event.*;

import javax.swing.event.*;

import java.util.Arrays;

public class Lab7 extends JFrame

{

private JButton calculateButton;

private String patterns;

private JSpinner number1;

private JComboBox operation;

private JSpinner number2;

JLabel display;

public static void main(String[] args)

{

Lab7 lab = new Lab7();

lab.create();

lab.setVisible(true);

}

Lab7()

{

super("Simple Calculator");

create();

}

void create()

{

setDefaultCloseOperation(EXIT_ON_CLOSE);

setLocationRelativeTo(null);

setSize(300, 300);

JPanel mainPanel = new JPanel();

mainPanel.setBorder(BorderFactory.createEmptyBorder(20, 20, 20, 20));

mainPanel.setLayout(new BorderLayout(4, 4));

add(mainPanel, BorderLayout.NORTH);

GridLayout gridLayout = new GridLayout(0, 1, 4, 4);

JPanel labelPanel = new JPanel();

mainPanel.add(labelPanel, BorderLayout.WEST);

labelPanel.setLayout(gridLayout);

labelPanel.add(new MyLabel("Number 1"));

labelPanel.add(new MyLabel("Operation"));

labelPanel.add(new MyLabel("Number 2"));

labelPanel.add(new JSeparator());

labelPanel.add(new MyLabel("="));

JPanel fieldPanel = new JPanel();

mainPanel.add(fieldPanel, BorderLayout.CENTER);

fieldPanel.setLayout(gridLayout);

//Spinner 1

number1 = new JSpinner(new SpinnerNumberModel(0,0-100, 0+100, 1));

number1.addChangeListener(new ChangeListener()

{

public void stateChanged(ChangeEvent e)

{

JSpinner spinner = (JSpinner)e.getSource();

int numvalue = ((Number)number1.getValue()).intValue();

String s = new String();

String one = s.valueOf(numvalue);

}

}

);

fieldPanel.add(number1);

//ComboBox

final String[] operators = new String[]{"+", "-", "x", "/"};

patterns = operators[0];

operation = new JComboBox(operators);

operation.addActionListener(new ActionListener()

{

public void actionPerformed(ActionEvent e)

{

JComboBox cb = (JComboBox)e.getSource();

//Selecting the options

String s = new String();

String two = s.valueOf(operation.getSelectedItem());

}

}

);

fieldPanel.add(operation);

//Spinner 2

number2 = new JSpinner();

number2.addChangeListener(new ChangeListener()

{

public void stateChanged(ChangeEvent e)

{

JSpinner spinner2 = (JSpinner)e.getSource();

int num2value = ((Number)number2.getValue()).intValue();

String s = new String();

String three = s.valueOf(num2value);

}

}

);

fieldPanel.add(number2);

//Separator

fieldPanel.add(new JSeparator());

//JTextField for final answer - maybe better to use TextArea instead

final JTextField result = new JTextField();

result.setEditable(false);

fieldPanel.add(result);

//Displaying the work space border

final JPanel workspace = new JPanel(new GridLayout(0, 1));

add(workspace, BorderLayout.CENTER);

display = new JLabel(" ");

display.setForeground(Color.blue);

display.setBorder(BorderFactory.createCompoundBorder(

BorderFactory.createLineBorder(Color.blue),

BorderFactory.createEmptyBorder(0,0,0,0)

));

JLabel la = new JLabel();

la.setText(one + two + three);/*<--*/

workspace.add(display);

//Displaying the work space content

JLabel content = new JLabel();

//Button

JPanel bottomPanel = new JPanel();

add(bottomPanel, BorderLayout.SOUTH);

calculateButton = new JButton("Calculate");

calculateButton.addActionListener(new ActionListener()

{

public void actionPerformed(ActionEvent e)

{

System.out.println("\nok");

}

}

);

bottomPanel.add(calculateButton);

}

public void equationDisplay(JSpinner arg0, String arg1, JSpinner arg2)

{

System.out.println(arg0 + " " + arg1 + " " + arg2);

}

private class MyLabel extends JLabel

{

public MyLabel(String text)

{

super(text);

setHorizontalAlignment(SwingConstants.RIGHT);

}

}

}

vopoa at 2007-7-29 19:27:30 >

Thanks its very useful, my code finally prints.

vopoa at 2007-7-29 19:27:34 >