abstract JInternalFrame

Ah, so no need to subclass. That will save me a lot of work I guess but I'm not sure I completely understand your solution.

In my case I have to write an application for a Doctors practice. I have classes like changePatientData. That class would use a JInternalFrame to display the data.

Code of a classdeclaration:public class changePatientData extends JInternalFrame

I have several others of these classes that all extend JInternalFrame in the same way. How would I implement your solution then? Sorry but I don't have that much of experience yet programming java and GUI's but I'd be grateful if you could clarify your solution.

Message was edited by:

Rockarena666

Rockarena666a at 2007-7-12 3:40:38 >

Some of the stuff will be in Dutch so sorry about that and really thank you for the help!

/*

* Toevoegen.java

*

* Created on 3 januari 2007, 20:47

*

* To change this template, choose Tools | Template Manager

* and open the template in the editor.

*/

package forms;

import ejb.*;

import java.awt.BorderLayout;

import java.awt.Color;

import java.awt.Container;

import java.util.List;

import java.util.Vector;

import javax.swing.*;

import java.awt.GridLayout;

import java.awt.event.*;

import javax.ejb.EJB;

import login.Login;

import login.LoginGegevens;

public class Toevoegen extends JInternalFrame implements MouseListener

{

public SuperFacadeRemote superfacadebean = Login.getSuperFacade();

public Container container;

public LoginGegevens logingeg;

public JPanel panel;

private JTextField txtNaam, txtVoornaam, txtEmail, txtTelnr, txtGsmnr, txtStraat, txtGemeente, txtPostcode, txtHuisnr, txtLand;

protected JButton therapeut, patient, arts,hoofdarts;

private JCheckBox mails;

private JLabel label;

protected JLabel foutlabel;

private JComboBox comboarts;

protected JPasswordField txtPaswoord,txtPaswoord2;

private JPanel titel;

protected String persoon;

private List listarts;

protected Persoon p;

private JList therapat;

public Toevoegen(LoginGegevens logingeg, String persoon)

{

super();

this.logingeg = logingeg;

this.persoon=persoon;

container = new Container();

container = getContentPane();

container.setLayout(new BorderLayout());

aanmakenKnoppen();

setPanel();

bewerkPersoon();

foutlabel = new JLabel("");

foutlabel.setForeground(Color.RED);

container.add(foutlabel, BorderLayout.SOUTH);

this.setMaximizable(true);

this.setClosable(true);

this.setResizable(true);

this.setLocation(0,0);

this.setSize(400,400);

this.setDefaultCloseOperation(DISPOSE_ON_CLOSE);

this.setVisible(true);

stresslabo.HoofdForm.dskp.add(this);

stresslabo.HoofdForm.dskp.moveToFront(this);

}

public void aanmakenKnoppen()//String persoon)

{

if (persoon.equals ("therapeut"))

{

therapeut = new JButton("Voeg toe");

therapeut.addMouseListener(this);

}

else

{

if(persoon.equals ("arts"))

{

arts = new JButton("Voeg toe");

arts.addMouseListener(this);

}

else

{

if(persoon.equals ("patient"))

{

patient = new JButton("Voeg toe");

patient.addMouseListener(this);

}

else

{

hoofdarts = new JButton("Voeg toe");

hoofdarts.addMouseListener(this);

}

}

}

/*therapeut = new JButton("Voeg toe");

therapeut.addMouseListener(this);

patient = new JButton("Voeg toe");

patient.addMouseListener(this);

arts = new JButton("Voeg toe");

arts.addMouseListener(this);*/

}

void setKnopteksten(String s)

{

if (persoon.equals ("therapeut"))

therapeut.setText(s);

else

{

if(persoon.equals ("arts"))

arts.setText(s);

else

{

if(persoon.equals ("patient"))

patient.setText(s);

else

hoofdarts.setText(s);

}

}

}

public void setPanel()//JPanel panel)

{

panel = new JPanel();

//panel.removeAll();

GridLayout gl = new GridLayout (16,2);

gl.setHgap(1);

gl.setVgap(1);

panel.setLayout(gl);

}

public void setTitel(String t)

{

titel = new JPanel();

titel.add(new JLabel(t));

container.add(titel, BorderLayout.NORTH);

}

public void bewerkPersoon ()

{

setTitel(persoon.toUpperCase() + " TOEVOEGEN");

persoonVelden();

if (persoon.equals("patient"))

addPatient();

paswoordVelden();

//leegVeld();

knopLeegmaken();

if(persoon.equals("therapeut"))

{

panel.add(therapeut);

}

else

{

if (persoon.equals("arts"))

panel.add(arts);

else

{

if (persoon.equals("patient"))

panel.add(patient);

else

panel.add(hoofdarts);

}

}

container.add(panel, BorderLayout.CENTER);

}

public void knopLeegmaken()

{

JButton leegmaken=new JButton("Velden leegmaken");

leegmaken.addMouseListener(new MouseAdapter() {

public void mouseReleased(MouseEvent e)

{

maakLeeg();

}

});

panel.add(leegmaken);

}

public void addPatient ()

{

label = new JLabel("Arts:");

panel.add(label);

/*-Lijsten aanmaken-*/

List<Arts> listarts = superfacadebean.geefArtsen(logingeg.getLogin(), logingeg.getPaswoord());

/*Test lijsten maken -*

listarts=maakList("arts");

/*-Einde TEST*/

comboarts = new JComboBox((Vector)listarts);

panel.add(comboarts);

}

public void addTherapeut()

{

panel.add(new JLabel("Pati雗ten:"));

therapat = new JList();

panel.add(therapat);

}

public void addConsultaties()

{

panel.add(new JLabel(""));

JButton consknop = new JButton("Consultaties");

consknop.addMouseListener(new MouseAdapter() {

public void mouseReleased(MouseEvent e)

{

new Consultaties(p);

}

});

panel.add(consknop);

}

/*TEST LIJSTEN */

public List maakList(String pers)

{

listarts = new Vector ();

Arts a=new Arts("aArts", "Jandslkjq", "arts@mail.com", "001122", "01475", true, new Adres ());

if (pers.equals("arts"))

{

listarts.add(new Arts("Verheyden", "Jan", "jan@mail.com", "001122", "01475", true, new Adres ()));

listarts.add(new Arts("Janssen", "Jandslkjq", "ja2n@mail.com", "00551122", "0142475", false, new Adres ()));

listarts.add(a);

}

else

{

if (pers.equals("therapeut"))

{

listarts.add(new Therapeut("Pieters", "Peter", "ja3@mail.com", "0014422", "0123475", true, new Adres ()));

listarts.add(new Therapeut("Thera", "Peut", "theaja3@mail.com", "110014422", "220123475", false, new Adres ()));

listarts.add(new Therapeut("Prens", "PTherapeutr", "japeut3@mail.com", "001244422", "023123475", true, new Adres ()));

}

else

{

listarts.add(new Patient("Patient", "odsqfs", "patient@mail.com", "00dfgsdf1122", "04561475", false, new Adres (),a));

listarts.add(new Patient("Patient2", "twee", "p22atient@mail.com", "0220dfgsdf1122", "0224561475", true, new Adres (),a));

//superfacadebean.geefPersonen();

}

}

return listarts;

}

/*EINDE TEST */

public void leegVeld()//JPanel panel)

{

label = new JLabel("");

panel.add(label);

}

public void persoonVelden()//JPanel panel)

{

label = new JLabel("Naam:");

panel.add(label);

txtNaam = new JTextField();

panel.add(txtNaam);

label = new JLabel("Voornaam:");

panel.add(label);

txtVoornaam = new JTextField();

panel.add(txtVoornaam);

if (!(persoon.equals("hoofdarts")))

{

adresVelden();//panel);

label = new JLabel("Email:");

panel.add(label);

txtEmail = new JTextField();

panel.add(txtEmail);

label = new JLabel("Telefoonnr:");

panel.add(label);

txtTelnr = new JTextField();

panel.add(txtTelnr);

label = new JLabel("GSMnr:");

panel.add(label);

txtGsmnr = new JTextField();

panel.add(txtGsmnr);

leegVeld();//panel);

mails = new JCheckBox("Emails ontvangen", true);

panel.add(mails);

}

}

public void paswoordVelden ()//JPanel panel)

{

label = new JLabel("Paswoord:");

panel.add(label);

txtPaswoord = new JPasswordField();

panel.add(txtPaswoord);

label = new JLabel("Herhaal paswoord:");

panel.add(label);

txtPaswoord2 = new JPasswordField();

panel.add(txtPaswoord2);

}

public void adresVelden ()//JPanel panel)

{

label = new JLabel("Straat:");

panel.add(label);

txtStraat = new JTextField();

panel.add(txtStraat);

label = new JLabel("Huisnr:");

panel.add(label);

txtHuisnr = new JTextField();

panel.add(txtHuisnr);

label = new JLabel("Postcode:");

panel.add(label);

txtPostcode = new JTextField();

panel.add(txtPostcode);

label = new JLabel("Gemeente:");

panel.add(label);

txtGemeente = new JTextField();

panel.add(txtGemeente);

label = new JLabel("Land:");

panel.add(label);

txtLand = new JTextField();

panel.add(txtLand);

}

public void mouseReleased(MouseEvent e)

{

boolean gelijk = paswoordenGelijk();

if (gelijk)

{

foutlabel.setText("");

String mail="", tel="", gsm="";

boolean m=false;

Adres a=null;

String paswoord = logingeg.omzettenPaswoord(txtPaswoord.getPassword());

//Persoon p;

String n = txtNaam.getText();

String vn = txtVoornaam.getText();

if (!(e.getSource().equals(hoofdarts)))

{

mail = txtEmail.getText();

tel = txtTelnr.getText();

gsm = txtGsmnr.getText();

m = mails.isSelected();

a = new Adres();

a.setStraat(txtStraat.getText());

a.setHuisnr(txtHuisnr.getText());

a.setPostcode(txtPostcode.getText());

a.setGemeente(txtGemeente.getText());

a.setLand(txtLand.getText());

}

if (e.getSource().equals(patient))

{

Arts ar = (Arts)comboarts.getSelectedItem();

System.out.println(""+ar);

p = new Patient (n, vn, mail, tel, gsm, m, a, ar);

System.out.println(p.toString());

superfacadebean.patientToevoegen((Patient)p, paswoord,logingeg.getLogin(), logingeg.getPaswoord());

}

else

{

if (e.getSource().equals(arts))

{

System.out.println(a.getStraat()+"");

System.out.println(n+""+vn+""+mail+""+tel+""+gsm+""+m+""+a+"");

p = new Arts(n, vn, mail, tel, gsm, m, a);

System.out.println(a+"=adres");

System.out.println(logingeg.getLogin()+"");

System.out.println(logingeg.getPaswoord()+"");

System.out.println(p+"");

System.out.println(paswoord);

System.out.println(p+"");

System.out.println(""+superfacadebean);

superfacadebean.artsToevoegen((Arts)p,paswoord,logingeg.getLogin(), logingeg.getPaswoord());

//panel.remove(arts);

}

else

{

if (e.getSource().equals(therapeut))

{

p = new Therapeut (n, vn, mail, tel, gsm, m, a);

System.out.println(p);

System.out.println(paswoord);

System.out.println("login: " + logingeg.getLogin());

System.out.println("pasw: " + logingeg.getPaswoord());

superfacadebean.therapeutToevoegen((Therapeut)p, paswoord, logingeg.getLogin(), logingeg.getPaswoord());

//panel.remove(therapeut);

}

}

}

setUnabled();

setPaswoordenUnabled();

setKnoppenUnabled();

}

else

foutlabel.setText("Paswoorden zijn niet gelijk");

}

public void setKnoppenUnabled()

{

if (persoon.equals("patient"))

patient.setEnabled(false);

else

{

if (persoon.equals("arts"))

arts.setEnabled(false);

else

therapeut.setEnabled(false);

}

}

public boolean paswoordenGelijk()

{

String pasw1 = logingeg.omzettenPaswoord(txtPaswoord.getPassword());

String pasw2 = logingeg.omzettenPaswoord(txtPaswoord2.getPassword());

if (pasw1.equals(pasw2))

return true;

else

return false;

}

public void mouseClicked(MouseEvent e) {

}

public void mousePressed(MouseEvent e) {

}

public void mouseEntered(MouseEvent e) {

}

public void mouseExited(MouseEvent e) {

}

public void setSelected (Persoon p)

{

this.p=p;

System.out.println("set" + p.toString());

}

public void setVelden()

{

if (p != null)

{

setNaam(p.getNaam());

setVoornaam(p.getVoornaam());

setEmail(p.getEmail());

setTelnr(p.getTelnr());

setGsmnr(p.getGsmnr());

//-ADRES GEGEVENS

setStraat(((Adres)(p.getAdres())).getStraat());

setGemeente(((Adres)(p.getAdres())).getGemeente());

setPostcode(((Adres)(p.getAdres())).getPostcode());

setHuisnr(((Adres)(p.getAdres())).getHuisnr());

setLand(((Adres)(p.getAdres())).getLand());

//--STOP ADRES GEGEVENS

setMailOntvangen(p.isEmailOntvangen());

//-ARTS GEGEVENS--

if (persoon.equals("patient"))

setComboarts(((Patient)p).getArts());

else

{//--STOP ARTS GEGEVENS-

if (p instanceof Therapeut)

{

//List<Patient> pat = ((Therapeut)p).getPatienten();

List<Patient> pat = superfacadebean.geefPatienten(logingeg.getLogin(), logingeg.getPaswoord());

if (pat != null)

therapat.setListData((Vector)pat);

}

}

}

}

public void setPaswoordenUnabled()

{

txtPaswoord.setEnabled(false);

txtPaswoord2.setEnabled(false);

}

public void setUnabled()

{

txtNaam.setEnabled(false);

txtVoornaam.setEnabled(false);

if (!(persoon.equals("hoofdarts")))

{

txtEmail.setEnabled(false);

txtTelnr.setEnabled(false);

txtGsmnr.setEnabled(false);

txtStraat.setEnabled(false);

txtGemeente.setEnabled(false);

txtPostcode.setEnabled(false);

txtHuisnr.setEnabled(false);

txtLand.setEnabled(false);

mails.setEnabled(false);

if (persoon.equals("patient"))

comboarts.setEnabled(false);

}

}

public void maakLeeg()

{

txtNaam.setText("");

txtVoornaam.setText("");

if (!(persoon.equals("hoofdarts")))

{

txtEmail.setText("");

txtTelnr.setText("");

txtGsmnr.setText("");

txtStraat.setText("");

txtGemeente.setText("");

txtPostcode.setText("");

txtHuisnr.setText("");

txtLand.setText("");

mails.setSelected(false);

if (persoon.equals("patient"))

comboarts.setSelectedIndex(0);

}

txtPaswoord.setText("");

txtPaswoord2.setText("");

}

public void setNaam(String n) {

txtNaam.setText(n);

}

public void setVoornaam(String n) {

txtVoornaam.setText(n);

}

public void setEmail (String n){

txtEmail.setText(n);

}

public void setTelnr (String n){

txtTelnr.setText(n);

}

public void setGsmnr (String n){

txtGsmnr.setText(n);

}

public void setStraat (String n){

txtStraat.setText(n);

}

public void setGemeente (String n){

txtGemeente.setText(n);

}

public void setPostcode (String n){

txtPostcode.setText(n);

}

public void setHuisnr (String n){

txtHuisnr.setText(n);

}

public void setLand (String n){

txtLand.setText(n);

}

public void setMailOntvangen(boolean b){

mails.setSelected(b);

}

public void setComboarts(Persoon a)

{

System.out.println("setarts: " + a);

comboarts.setSelectedItem((Arts)a);

/*int index=0;

System.out.println(comboarts.getItemCount() + "=count");

System.out.println(comboarts.getItemAt(0));

for (int i=0; i<comboarts.getItemCount(); i++)

{

System.out.println(a);

System.out.println(comboarts.getItemAt(i));

if (((Persoon)a).equals((Persoon)comboarts.getItemAt(i))){

index=i;

System.out.println("gelijk " + (Arts)comboarts.getItemAt(i));

}

}

System.out.println("index: "+ index);

comboarts.setSelectedIndex(index);*/

comboarts.repaint();

}

public String getNaam(){

return txtNaam.getText();

}

public String getVoornaam(){

return txtVoornaam.getText();

}

public String getEmail(){

return txtEmail.getText();

}

public String getTelnr(){

return txtTelnr.getText();

}

public String getGsmnr(){

return txtGsmnr.getText();

}

public boolean getMails(){

return mails.isSelected();

}

public String getStraat(){

return txtStraat.getText();

}

public String getHuisnr(){

return txtHuisnr.getText();

}

public String getPostcode(){

return txtPostcode.getText();

}

public String getGemeente(){

return txtGemeente.getText();

}

public String getLand(){

return txtLand.getText();

}

public Arts getArts(){

System.out.println("geselecteerde arts:" +(Arts)comboarts.getSelectedItem());

return (Arts)comboarts.getSelectedItem();

}

}

>

Rockarena666a at 2007-7-12 3:40:38 >

Nice, very nice! I didn't know that was allowed! Now I was thinking with this new information that it has to be possible to declare a JInternalFrame the way I want it and then re use it whenever I feel the need. The problem is as follows: what if at any given time I want to change the default_close_operation of my frames? Then I would have to change that in 10 different places. So using your new information I could easily define a frame like I want it to be and then re use it anywhere I want.

If you still feel up to it I would like to know some more of separating the GUi from the underlying data. I think you make a really good point there. Would you put the methods used in this Frame somewhere else then or am I misunderstanding you? Thanx for the help, it's greatly appreciated! My first review of this program by my teacher was not good and I want to do something about it desperately.

Rockarena666a at 2007-7-12 3:40:38 >

I'm already working with that a bit. I'm using Enterprise java beans so a lot of my logic is already separated from my view but I will take a look at it and try to expand this idea.

Would you agree on my idea to define a class that I could re use so all my InternalFrame stuff is in one place and I could then instantiate the class in every other class that needs an Internal Frame?

Rockarena666a at 2007-7-12 3:40:38 >