GUI freeze problem

You shouldn't do a long time-consuming task in a GUI event handler because Java GUI runs as a single thread. Delegate the task to a separate thread. See below.

public class XXXGUI{

public void actionPerformed(ActionEvent ae){

if (ae.getSource() == boton){

boton.setEnabled(false);

new Thread(new StartServer()).start();

else{

s3.terminar();

}

}

}

class StartServer implements Runnable{

int clientes;

ServerSocket s;

public void run(){

clientes = ContadorClientes.contar("conectados.txt");

try{

s = new ServerSocket(12345);

System.out.println("Server Started. Waiting for connections...");

for (int i = 1; i <= clientes; ++i){

Socket sc = s.accept();

System.out.println("New Client Connected with id " + i );

// Thread t = new Servert3(sc, i); // wrong

Servert3 t = new Servert3(sc, i);

t.start();

}

}

catch (Exception e){

e.printStackTrace();

}

}

}

Message was edited by:

hiwa

hiwaa at 2007-7-12 3:05:09 >

Delete the try/catch in the for loop!!!!!

Your client has problem.

You are suppressing the precious information from Java runtime:

catch (Exception e){

System.out.println("Error en servidor");

}

Do like this and post the exception output:

catch (Exception e){

e.printStackTrace();

}

Message was edited by:

hiwa

Message was edited by:

hiwa

hiwaa at 2007-7-12 3:05:09 >

Like you say hiwa maybe the problems is the client, i posted in other post, but is not problem to post it again, thanks!!!

import java.net.*;

import java.io.*;

public class RecivirArchivoEncriptado2{

String fileCharSet;

String separator;

Socket clientsocket;

BufferedReader socketInput;

String s;

public RecivirArchivoEncriptado2(){

fileCharSet = "UTF-8";

separator = "##$##$##";

try {

clientsocket = new Socket("127.0.0.1", 12349);

socketInput = new BufferedReader

(new InputStreamReader(clientsocket.getInputStream(), fileCharSet));

}

catch (Exception e){

e.printStackTrace();

}

}

public void doFileGet(){

try{

PrintWriter fileOutput

= new PrintWriter(new FileOutputStream("archivoEncriptado.txt"), true);

while ((s = socketInput.readLine()) != null){

if (s.equals(separator)){

break;

}

fileOutput.println(s);

}

fileOutput.close();

fileOutput.flush();

System.out.println("archivo encriptado recivido");

fileOutput

= new PrintWriter(new FileOutputStream("archivoPlano.txt"), true);

while ((s = socketInput.readLine()) != null){

fileOutput.println(s);

}

fileOutput.flush();

fileOutput.close();

System.out.println("archivo plano recivido");

socketInput.close();

clientsocket.close();

}

catch(IOException e) {

System.out.println("conection refused port 12345");

}

}}

big_rota at 2007-7-12 3:05:09 >

Ok, yes i have to start it once, but because i have to prove the code, i have to run and run it, tnanks hiwa, now thats not the problem, i think the problem now is the client, which code is there, again its getting the .txt empty, why can it be happening this, if i don't use the thread, it works ok, but now with the threads the client freezes!!! **** i used this word a lot in this program lol, but i don't know why, please hiwa, and any one that want to, i need ur help, thanks

big_rota at 2007-7-12 3:05:09 >

Ok, lets see, the fact here is that i have to send the same files to different clients,

ok here is all about my program:

The application is a server that reads a file with the number of clients that

will connect to them, thats why the number off threads created are clients.number(),

then when a client is connected the Server sends an

encrypted file, a plain text file, 2 numbers (a range of numbers like

1-100000).

Then the client uses a class that make the number to a string, encode it

and encrypt the file with the encoded string, then it compares the file and if

it is the same it has to send a message to the server like ("I have the key, it

is HIWA")

and the server has to send a message to the other clients and say them

(Ok stop the process). Thats why i need to send the same file to each

client, any code u need i will happily send it to you. And when the stop

button is pressed, it sends a message to all clients and tell them ("stop the

process"), and the clients respond ("I tried keys from x to y"), i know is a

kind of bad explanation but any doubt i will answer :).

big_rota at 2007-7-21 20:30:30 >

here is my client threaded socket

import java.net.*;

import java.io.*;

public class recivirArchivoEncriptado2 implements Runnable{

String fileCharSet;

String separator;

Socket clientsocket;

BufferedReader socketInput;

String s;

public recivirArchivoEncriptado2(){

fileCharSet = "UTF-8";

separator = "##$##$##";

try {

clientsocket = new Socket("127.0.0.1", 1242);

socketInput = new BufferedReader

(new InputStreamReader(clientsocket.getInputStream(), fileCharSet));

}

catch (Exception e){

e.printStackTrace();

}

}

public void run(){

try{

PrintWriter fileOutput

= new PrintWriter(new FileOutputStream("archivoEncriptado.txt"), true);

fileOutput.flush();

System.out.println("Conectado");

while ((s = socketInput.readLine()) != null){

if (s.equals(separator)){

System.out.println("Conectado");

break;

}

fileOutput.println(s);

}

fileOutput.flush();

fileOutput.close();

System.out.println("archivo encriptado recivido");

fileOutput

= new PrintWriter(new FileOutputStream("archivoPlano.txt"), true);

while ((s = socketInput.readLine()) != null){

fileOutput.println(s);

}

fileOutput.flush();

fileOutput.close();

System.out.println("archivo plano recivido");

socketInput.close();

clientsocket.close();

System.out.println("Archivo recivido con exito");

}

catch(IOException e) {

System.out.println("conection refused port 1234");

}

}}

and my clients gui:

import java.awt.*;

import java.awt.event.*;

import javax.swing.*;

import java.io.*;

import java.lang.*;

import java.net.*;

import java.io.Writer;

public class GUI extends JFrame implements ActionListener{

public JTextField texto;

public JTextArea texto2;

recivirArchivoEncriptado2 e;

public JButton boton,boton2;

public JPanel p1,p2,p3,p4,p51;

public JFrame frame2;

public GUI(){

frame2=new JFrame();

frame2.setSize(200,200);

p51=new JPanel();

p51.setPreferredSize(new Dimension(200,200));

texto=new JTextField(10);

texto2=new JTextArea(10,10);

boton=new JButton("Plano");

boton2=new JButton("Encriptado");

boton.addActionListener(this);

boton2.addActionListener(this);

p1=new JPanel();

p2=new JPanel();

p3=new JPanel();

p4=new JPanel();

p1.setPreferredSize(new Dimension(900,600));

p2.setPreferredSize(new Dimension(200,600));

p3.setPreferredSize(new Dimension(300,600));

p4.setPreferredSize(new Dimension(200,600));

}

public void actionPerformed(ActionEvent ae){

Thread t=new Thread(new recivirArchivoEncriptado2());

t.start();

}

private void createAndShowGUI() {

setTitle("Proyecto Final");

setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

JLabel emptyLabel = new JLabel("");

p51.add(boton2);

p51.setVisible(true);

p2.add(texto2);

boton.setVisible(true);

boton2.setVisible(true);

p1.setVisible(true);

p2.setVisible(true);

boton.setVisible(true);

getContentPane().add(p1);

p1.add(p2);

p1.add(p3);

p1.add(p4);

pack();

setVisible(false);

frame2.getContentPane().add(p51);

frame2.pack();

frame2.setVisible(true);

}

public static void main(String[] args) {

final GUI g=new GUI();

javax.swing.SwingUtilities.invokeLater(new Runnable() {

public void run() {

g.createAndShowGUI();

}

});

}

}

THanks

big_rota at 2007-7-21 20:30:30 >

Ok, i put

public synchronized void run()

on both sides client and server, and still doesn't work, so I decided to upload all my file so if any doubt there it is the link is:

http://files-upload.com/198900/workspace3.zip.html

Anyway questions i could answer, thanks again

big_rota at 2007-7-21 20:30:30 >

And what do you mean, synchronize the file I/O, i just can synchronize methods, do you mean something like

public synchronized void encriptado(String a1){try{

fileInput= new BufferedReader(new InputStreamReader

(new FileInputStream(a1), fileCharSet));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

fileInput.close();

socketOutput.println(separator);

socketOutput.flush();

System.out.println("archivo encriptado enviado");

socketOutput.flush();

System.out.println("archivo plano enviado");

}catch(Exception e){e.printStackTrace();

}

}

big_rota at 2007-7-21 20:30:30 >

Oh men now i have another problem, the file stuff is OK, just perfect, but now i want to send 2 integers to the clients, both are generated at runtime, but the client freezes, again, look my code:

public void dogetInt(){

try{

DataInputStream dis=new DataInputStream(clientsocket.getInputStream());

System.out.println(dis.readLong());

System.out.println(dis.readLong());

dis.close();

}

catch(Exception e){

e.printStackTrace();

}

at the recivirArchivoEncriptado2

public void actionPerformed(ActionEvent ae){

e.dogetInt();

e.doFileGet();

}

at the clients GUI.

import java.io.*;

import java.net.*;

public class NewServert3 extends Thread{

String fileCharSet;

String separator;

String s;

String archivo1, archivo2;

ServerSocket serversocket;

public Socket incoming;

int counter ;

long ini, finale;

public NewServert3(Socket i, int c, String a1, String a2,long inicio,long finnal){

archivo1 = a1;

archivo2 = a2;

ini=inicio;

finale=finnal;

fileCharSet = "UTF-8";

separator = "##$##$##";

Chronometer.start();

incoming = i;

counter = c;

}

public void run(){

doSendRange();

doFileSend();

}

public synchronized void doSendRange(){

try{

DataOutputStream dos = new DataOutputStream(incoming.getOutputStream());

dos.writeLong(ini);

dos.writeLong(finale);}

catch(Exception e){

e.printStackTrace();

}

}

public synchronized void doFileSend(){

try{

PrintWriter socketOutput

= new PrintWriter(incoming.getOutputStream(), true);

BufferedReader fileInput = new BufferedReader(new InputStreamReader

(new FileInputStream(archivo1), fileCharSet));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

fileInput.close();

socketOutput.println(separator);

socketOutput.flush();

System.out.println("archivo encriptado enviado");

fileInput = new BufferedReader(new FileReader(archivo2));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

socketOutput.flush();

fileInput.close();

socketOutput.close();

incoming.close();

Chronometer.stop();

System.out.print((int)Chronometer.htime() + ":");

System.out.print((int)Chronometer.mtime() + ":");

System.out.print((int)Chronometer.stime() + ":");

}

catch (IOException e) {

e.printStackTrace();}

}

public void terminar(){

try{

incoming.close();

Chronometer.stop();

System.out.print((int)Chronometer.htime() + ":");

System.out.print((int)Chronometer.mtime() + ":");

System.out.print((int)Chronometer.stime() + ":");

}

catch(Exception e){

e.printStackTrace();

}

}

}

the server code, thanks.

big_rota at 2007-7-21 20:30:30 >

Ok thats solved hiwa, i threaded the long issue, now the last problem id this:

in the server side there is a button that if clicked say to all the clients to stop the process and then close the client, and the other thing, if any client find the right "key" to the server and all clients will stop the process they are doing and close port, how could i do this, thanks

Thanks again man!!

big_rota at 2007-7-21 20:30:35 >

Well my friend hiwa, with "find" i meant transform the int to a string, encrypt the file with it, compare with the encrypted file and get true, i mean, that the client get the key with i for loop, mm i don't know if its clear, i mean the server and all the clients are searching for a key, thats the purpose of the program, thanks

big_rota at 2007-7-21 20:30:35 >

Don't know if i didn't explain my point or if you're just asking if you understand right my point, what i meant is:

server sends 2 files and 2 ints to the clients

the 2 ints are a range of number i meant the first client connected receives from 100000 to 200000 lets say, the server uses range 1 to 99999, the next client 2000001 to 300000 etc... each client and the server uses a class that with a loop, lets say the key is HIWA so the number is 1560000 (not really just an example), so the client 1 that found that the key is 15600000, at the moment the client realize that, tell the server hey i found the key (lets said with a non null string), so the server said, ok every one stops the loop!! and then the server prints "Client 1 found the key its HIWA" and stop the program, maybe with a bool that ask if an OutputStream is empty or a method, i don't have a clue lol

big_rota at 2007-7-21 20:30:35 >

I'M having another weird problem pliz man help,

the file plain.txt is received with like 5 white spaces i don't know why, i did what you said, here is code of that:

CLIENT SIDE:

public void doFileGet(){

try{ PrintWriter fileOutput

= new PrintWriter(new FileOutputStream("archivoEncriptado.txt"), true);

fileOutput.flush();

System.out.println("Conectado");

while ((s = socketInput.readLine()) != null){

if (s.equals(separator)){

System.out.println("Conectado");

break;

}

fileOutput.println(s);

}

fileOutput.flush();

fileOutput.close();

System.out.println("archivo encriptado recivido");

fileOutput

= new PrintWriter(new FileOutputStream("archivoPlano.txt"), true);

while ((s = socketInput.readLine()) != null){

fileOutput.println(s);

}

fileOutput.flush();

fileOutput.close();

System.out.println("archivo plano recivido");

socketInput.close();

clientsocket.close();

System.out.println("Archivo recivido con exito");

}

catch(IOException e) {

System.out.println("conection refused port 1234");

SERVER SIDE :

public synchronized void doFileSend(){

try{

PrintWriter socketOutput

= new PrintWriter(incoming.getOutputStream(), true);

BufferedReader fileInput = new BufferedReader(new InputStreamReader

(new FileInputStream(archivo1), fileCharSet));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

fileInput.close();

socketOutput.println(separator);

socketOutput.flush();

System.out.println("archivo encriptado enviado");

fileInput = new BufferedReader(new FileReader(archivo2));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

socketOutput.flush();

fileInput.close();

socketOutput.close();

incoming.close();

Chronometer.stop();

System.out.print((int)Chronometer.htime() + ":");

System.out.print((int)Chronometer.mtime() + ":");

System.out.print((int)Chronometer.stime() + ":");

}

catch (IOException e) {

e.printStackTrace();}

}

Both are threaded, If this not the problem i can put my code of send an integer, thanks

big_rota at 2007-7-21 20:30:35 >

This is my last post in this thread. You must learn Java language and Java programming basics before anything else.

Single I/O methods should be like this:

public synchronized void doFileSend(){

try{

DataOutputStream dos = new DataOutputStream(incoming.getOutputStream());

dos.writeLong(ini);

dos.writeLong(finale);

dos.writeInt(key);

dos.flush();

PrintWriter socketOutput

= new PrintWriter(incoming.getOutputStream(), true);

BufferedReader fileInput = new BufferedReader(new InputStreamReader

(new FileInputStream(archivo1), fileCharSet));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

fileInput.close();

socketOutput.println(separator);

socketOutput.flush();

System.out.println("archivo encriptado enviado");

fileInput = new BufferedReader(new FileReader(archivo2));

while ((s = fileInput.readLine()) != null){

socketOutput.println(s);

}

socketOutput.flush();

fileInput.close();

socketOutput.close();

incoming.close();

//Chronometer.stop(); // stop using class methods here in a thread

//System.out.print((int)Chronometer.htime() + ":");

//System.out.print((int)Chronometer.mtime() + ":");

//System.out.print((int)Chronometer.stime() + ":");

}

catch (IOException e) {

e.printStackTrace();

}

}

public void terminar(){

try{

incoming.close();

// Chronometer.stop();

// System.out.print((int)Chronometer.htime() + ":");

// System.out.print((int)Chronometer.mtime() + ":");

// System.out.print((int)Chronometer.stime() + ":");

}

catch(Exception e){

e.printStackTrace();

}

}

--

long ini, fin;

int key;

public void doFileGet(){

try{

DataInputStream dis = new DataInputStream(clientsocket.getInputStream());

ini = dis.readLong();

fin = dis.readLong();

key = dis.readInt();

/* DON'T DO THIS IN THE CONSTRUCTOR */

socketInput = new BufferedReader

(new InputStreamReader(clientsocket.getInputStream(), fileCharSet));

PrintWriter fileOutput

= new PrintWriter(new FileOutputStream("a1.txt"), true);

while ((s = socketInput.readLine()) != null){

if (s.equals(separator)){

break;

}

fileOutput.println(s);

}

fileOutput.close();

System.out.println("archivo encriptado recivido");

fileOutput

= new PrintWriter(new FileOutputStream("a2.txt"), true);

while ((s = socketInput.readLine()) != null){

fileOutput.print(s);

}

fileOutput.close();

System.out.println("archivo plano recivido");

socketInput.close();

clientsocket.close();

}

catch(IOException e) {

e.printStackTrace();

}

}

hiwaa at 2007-7-21 20:30:36 >