Swing - Ensuring the UI responds and updates...

I can't see anything obvious from that code that will cause problems - you're right in performing the "accept()" call away from the EDT if it involves file access. Might be an idea to give the method a name that gives a better hint as to its implications though - eg "verifyFile()" or something.

All I can offer at the moment is the statement that a grey area like you're seeing is nearly always a time-consuming piece of code being executed on the EDT, holding off a repaint until it's complete. If you read between the lines there, it may not even be one of your bits of code that's doing it - it's possible that some internal Swing code is just taking a bit of time.

itchyscratchya at 2007-7-10 14:15:06 >

If I'm correct the actionPerformed() occurs in the EDT, the addInputToJTable() is set off into a sepearate thread, so the setVisible() and dispose() should occur right away.

That's pretty much correct, the caveat being that firing the new thread firstly incurs a slight cost but also may result in some of the new thread being executed before returning - but, in practical terms, you're right.

However, the bit you're worried about isn't the delay before setVisible() and dispose(), but the delay between those calls and the subsequent repaint of the parent frame.

itchyscratchya at 2007-7-10 14:15:06 >

More help needed...

I'cannot seem to get the gray rectangle to go away. There are quite a few

places where I have similiar code, but the most "sluggish" is as follows:

The main application is a JFrame with a JTable and a JButton (amongst other

things). The actionPerformed() for this JButton displays a JDialog

containing a JTable with data.

Basically what I am doing is pressing a button on the main application

to display a dialog containing a table with data populated from a

database. There is one column in this table and it contains rows of

Strings. I can then select a row from it to add to the main table.

This SearchDialog stays visible so I can go back and forth selecting

one row at a time to be added to the main JTable.

There are 3 files:

Application.java, SearchDialog.java, InputNameDialog.java

The Application has the following code for handling the button

events. It creates the searchDialog.

[Application.java]

public void actionPerformed(ActionEvent e)
{
if (e.getSource() == displaySearchDialogButton)
{
 searchDialog = new SearchDialog(this);
}
}
When you select a row from the JTable in the SearchDialog, the
MouseListener responds to the event.
[SearchDialog.java]
public void mousePressed(MouseEvent e)
{
int rowIndex = table.getSelectedRow();
int columnIndex = table.getSelectedColumn();
Object selectedItem = table.getModel().getValueAt(rowIndex, columnIndex);
application.handleSelectedItem(selectedItem);
}
The application is then passed the selectedItem to be handled. If a name
is required, the InputNameDialog is displayed to obtain this information.
Otherwise the Application adds the selectedItem to its JTable.
There is some processing to do with the selectedItem which could be
time consuming so I'll shorten that to doBusyWork.
[Application.java]
public void handleSelectedItem(Object selectedItem)
{
if (requiresName)
{
 InputNameDialog dialog = new InputNameDialog(this, selectedItem);
}
else
{
 // Add data to table without a name specified.
 Vector<Object> rowData = new Vector<Object>();
 rowData.add("");
 rowData.add(selectedItem);
 ((DefaultTableModel)mainTable.getModel()).addRow(rowData);
 Thread t = new Thread(new Runnable()
 {
 doBusyWork(selectedItem);
 });
 t.start();
}
}
The InputNameDialog contains a JTextField where the I can enter
a Name, and click Ok or Cancel.
If I enter a name and select the Ok button, both the name and
selectedItem are passed to the application to be handled.
Cancel, simple disposes of the InputNameDialog and neither the name
nor the selectedItem are handled.
[InputNameDialog.java]
public void actionPerformed(ActionEvent e)
{
if (e.getSource() == okButton)
{
 String name = textfield.getText();
 application.handleNameAndSelectedItem(name, selectedItem);
}
dispose();
}
The Application then adds the data to its JTable, and brings the
SearchDialog back to the front so I can select another row.
Again there is some processing to do with the selectedItem which
could be time.
[Application.java]
public void handleNameAndSelectedItem(String name, Object selectedItem)
{
Vector<Object> rowData = new Vector<Object>();
rowData.add(name);
rowData.add(selectedItem);
((DefaultTableModel)mainTable.getModel()).addRow(rowData);
searchDialog.textfield.requestFocus();
searchDialog.setVisible(true);
Thread t = new Thread(new Runnable()
{
 doBusyWork(selectedItem);
});
t.start();
}
The SearchDialog is displayed. I can select a row and add it
to the table if no name is required. The focus stays on the
SearchDialog and there's no repaining issues.
However, if I need to display the InputNameDialog, when I
select the Ok button, there is a gray rectangle behind the
closing InputNameDialog -- and as the SearchDialog comes back
to the front, the SearchDialog isn't repainted immediately.
You can see a gray/tan color on the area of the SearchDialog that
was covered by the Application.
I don't see anything that is holding up the EventQueue and I
need this to update smoother.
Help ?
-Deba at 2007-7-10 14:15:06 >